Avoid extra parens for wildcard type signature #2764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add some tests for the examples you give in the PR description? |
michaelpj
approved these changes
Mar 8, 2022
|
@michaelpj there are now tests for the tuple, list and unit type. 🙂 |
+ avoid parens in simple cases (a, Char, [a], (),...) - change one test - (Int)/Int
|
(circleci did not finish so I rebased on master to give it a second chance) |
michaelpj
reviewed
Mar 9, 2022
| [ "func :: _" | ||
| , "func x y = x + y" | ||
| ] | ||
| [ "func :: (Integer -> Integer -> Integer)" |
There was a problem hiding this comment.
Hmmm, I guess it's not easy to tell if the hole is the entirety of the type signature? That seems like the remaining slightly bad case, and also probably a relatively common one...
There was a problem hiding this comment.
Anyway, that can be future work.
|
Thanks for this! |
July541
pushed a commit
to July541/haskell-language-server
that referenced
this pull request
Mar 30, 2022
+ avoid parens in simple cases (a, Char, [a], (),...) - change one test - (Int)/Int Co-authored-by: Ondrej Sebek <ondrej.sebek@mavenir.com>
sergv
added a commit
to sergv/haskell-language-server
that referenced
this pull request
May 26, 2022
A followup to haskell#2764
sergv
added a commit
to sergv/haskell-language-server
that referenced
this pull request
May 26, 2022
This is a followup to haskell#2764.
sergv
added a commit
to sergv/haskell-language-server
that referenced
this pull request
May 26, 2022
This is a followup to haskell#2764.
michaelpj
pushed a commit
that referenced
this pull request
May 27, 2022
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
* Omit more parens for wildcard type signature (haskell#2929) This is a followup to haskell#2764. * Review suggestions
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid parentheses in simple cases (
a,Char,(),...).The good news is, that getting types inside tuples and lists will not force you to apply hint "Redundant brackets":
The caveat is that it is still context unaware (works on text only) and the common use case of
f :: _is not improved.