Abbreviate explicit import code lenses

[michaelpj]

The tests currently don't check anything about the titles, I'm unsure
whether it's worth writing a test just for this.

Fixes #2765.

Demo:

[pepeiborra]

You could extract the new logic into a pure function. Then you can test it easily without involving lsp-test.

Although ultimately we also want an lsp test to ensure that the logic doesn't get removed accidentally.

[michaelpj]

Great point, I'll add a test for the abbreviation function.

[michaelpj]

I added some tests, which was good, because it was broken :) one day I will not be surprised by this.

[dariooddenino]

Hi, this is my version of hls:

❯ haskell-language-server-wrapper --version
haskell-language-server version: 1.6.1.1 (GHC: 9.0.2) (PATH: ~/.local/bin/haskell-language-server-wrapper) (GIT hash: 8466bc11a655f4cfbc8f228e527c2a7bf6762c7f)

which should already include this pr.

I'm still seeing incredibly long code lenses for explicit import. Am I missing anything?

Thanks!

[michaelpj]

I don't think this PR is in a released version yet.

[dariooddenino]

It looks like this was merged into master 21 days ago, and I manually built hls from a much more recent commit.
Now I feel like I'm missing something incredibly obvious. Sorry for the confusion.

[michaelpj]

Can you provide a reproduction?

[dariooddenino]

Sure!
https://github.com/dariooddenino/pru

This is what I see from src/Handler/Home.hs:

[jhrcek]

The thing I'd check is whether the haskell-language-server-wrapper that you have in your PATH is the actual binary that is being run by your editor. Can you check some tree view of running processes and check the command that your editor used to start hls? E.g on my linux I can use htop --tree to see that my vscode started hls using the following command.

You will likely find out that your editor has started different hls binary than the one you're showing version of..

[dariooddenino]

@jhrcek You are right.
I even checked emacs' path and tried running manually hls from within it, but didn't think about the obvious solution of checking the running process.
Sorry, and thanks to you all!

[michaelpj]

Cannot reproduce indeed:

However the "Refine import" lens is still massive and could do with this treatment.