Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add .txt files as extra-source-files for hls-change-type-signature-plugin #2887

Merged

Conversation

cdepillabout
Copy link
Contributor

@cdepillabout cdepillabout commented May 2, 2022

hls-change-type-signature-plugin appears to have a few .txt files that are necessary for running tests, but those files haven't been added to extra-source-files in hls-change-type-signature-plugin.

This appears to be causing errors when we try to build hls-change-type-signature-plugin in Nixpkgs: https://hydra.nixos.org/build/175155441/nixlog/1.

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pepeiborra pepeiborra merged commit 40acece into haskell:master May 2, 2022
@cdepillabout cdepillabout deleted the hls-change-type-signature-test-files branch May 2, 2022 08:20
sloorush pushed a commit to sloorush/haskell-language-server that referenced this pull request May 21, 2022
hololeap pushed a commit to hololeap/haskell-language-server that referenced this pull request Aug 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants