Skip to content

Modify ghcide requirements of hls-change-type-signature-plugin #2889

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 2, 2022

Conversation

July541
Copy link
Collaborator

@July541 July541 commented May 2, 2022

Reference #2884, I think hls-change-type-signature-plugin should also require ghcide >=1.7 since it uses printOutputable.

-- | Pretty Print the Type Signature (to validate GHC Error Message)
sigToText :: Sig GhcPs -> Maybe Text
sigToText = \case
ts@TypeSig {} -> Just $ stripSignature $ printOutputable ts
_ -> Nothing

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @July541 I'll do a Hackage revision as well

@pepeiborra pepeiborra merged commit 7bd6e08 into haskell:master May 2, 2022
sloorush pushed a commit to sloorush/haskell-language-server that referenced this pull request May 21, 2022
hololeap pushed a commit to hololeap/haskell-language-server that referenced this pull request Aug 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants