Set up partial functions ratchet #2974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
requested review from
jneira,
Anton-Latukha,
Ailrun and
pepeiborra
as code owners
hasufell
reviewed
Jun 20, 2022
hasufell
reviewed
Jun 20, 2022
|
CI error: |
michaelpj
force-pushed
the
mpj/partial-functions-ratchet
branch
from
ca9c443 to
46d8dc5
Compare
|
Rebased and added exceptions for the new stuff, added |
|
I am very confused about how the changes I've made can affect some test in the func test suite 🤔 |
|
I think it must be picking up the hlint config. |
michaelpj
force-pushed
the
mpj/partial-functions-ratchet
branch
from
c424232 to
0b5c3ec
Compare
|
Yep, that was it. |
|
How can I be getting ghcide test failures????? |
There can be many reasons on windows:
|
michaelpj
force-pushed
the
mpj/partial-functions-ratchet
branch
from
ddb607d to
08771a1
Compare
|
I rebased, let's see if it reoccurs. |
|
And now it's happy 🤷 |
|
Anyone like to approve? |
July541
approved these changes
Jun 23, 2022
|
I'll leave it a day or two in case anyone else has opinions :) |
|
Love it. Now I really don't have any excuse for not starting to remove individual partial functions one by one 😄 |
eddiemundo
approved these changes
Jun 24, 2022
pepeiborra
approved these changes
Jun 24, 2022
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
* HLint partial functions * Delete commented out stuff * Delete flag-based warnings, unclear they add much * Delete DA-specific hints * Delete extra cpp args * Delete extension options relating to dead build system * Don't bother trying to restrict CPP for now, it's everywhere * Make the hlint job fail if there are any errors * Fix for rebase, add unsafePerformIO and fold1 variants * Add some more indexing functions * Try turning off hlint on this test file * Add .hlint.yaml file for hls-hlint-plugin Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghcide.hlint.yamlto the top-level.hlint.yaml.hlint.yaml.