Skip to content

upgrade ghc-check to fix #3002 #3034

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Aug 19, 2022
Merged

upgrade ghc-check to fix #3002 #3034

merged 6 commits into from
Aug 19, 2022

Conversation

kokobd
Copy link
Collaborator

@kokobd kokobd commented Jul 11, 2022

I've made some changes in my fork of ghc-check: kokobd/ghc-check@3522cc2. It does solve the problem for the specific environment mentioned in #3002. But I haven't succeeded constructing a smaller reproducing environment. I'm going to check the CI results here, to see if it breaks something.

@kokobd
Copy link
Collaborator Author

kokobd commented Aug 15, 2022

This should close #3002

@pepeiborra
Copy link
Collaborator

ghc-check 0.5.0.8 is now in Hackage including this fix

@kokobd kokobd linked an issue Aug 15, 2022 that may be closed by this pull request
@kokobd kokobd marked this pull request as ready for review August 15, 2022 09:47
@kokobd
Copy link
Collaborator Author

kokobd commented Aug 15, 2022

Ah, yes, I've upgraded ghc-check to the latest version. Let's see if CI will pass.

@pepeiborra pepeiborra enabled auto-merge (squash) August 18, 2022 20:14
@pepeiborra pepeiborra merged commit fe00b3a into master Aug 19, 2022
sloorush pushed a commit to sloorush/haskell-language-server that referenced this pull request Sep 12, 2022
@kokobd kokobd deleted the kokobd/fix-no-lib-ghc branch July 23, 2023 00:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[partial function] Map.!: given key is not an element in the map
2 participants