-
-
Notifications
You must be signed in to change notification settings - Fork 392
Fix #3047 #3092
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix #3047 #3092
Conversation
/cc @andrewufrank |
Excuse me for this drive-by review, I was just looking at it and found the usage of |
I'll try to evaluate the usage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome!
* Make path canonicalized * Update extra-source-files * Replace with normalise * Change to a more detailed log * Comment patch detail * 2 spaces indent
It is because of the difference between
hs-source-dirs: ./
andhs-source-dirs: .
, take/user/project/Lib/A.hs
as example,hs-source-dirs: ./
hs-source-dirs: .
The canonicalized project path will be used as the prefix for
/user/project/Lib/A.hs
Canonicalized it to prevent dropping one more character.