Skip to content

Enable support for 9.4 on windows #3132

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Sep 2, 2022
Merged

Enable support for 9.4 on windows #3132

merged 8 commits into from
Sep 2, 2022

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Sep 1, 2022

  • Revert "drop windows for 9.4.2"
  • Fix entropy to 0.4.1.10 to fix build on windows

@wz1000 wz1000 force-pushed the wip/hls-9.4-windows branch from 598d6ab to 7cb3f7c Compare September 1, 2022 11:35
@wz1000
Copy link
Collaborator Author

wz1000 commented Sep 1, 2022

@guibou thanks for your help, but it seems like the Nix build is still failing, with a much worse error this time. I guess the last patch got merged because the Nix job is not required to merge.

@wz1000 wz1000 force-pushed the wip/hls-9.4-windows branch from a2fac97 to 0f7d5af Compare September 1, 2022 12:14
@wz1000 wz1000 requested a review from pepeiborra as a code owner September 2, 2022 11:52
@wz1000 wz1000 enabled auto-merge (rebase) September 2, 2022 12:24
@wz1000 wz1000 requested a review from michaelpj September 2, 2022 12:25
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wz1000 wz1000 merged commit 5b229b6 into master Sep 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants