-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update refactor/splice/hlint/fourmolu/retrie/gadt plugin for GHC 9.4 #3317
Merged
Merged
Changes from 83 commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
5b93df7
Set buildable on GHC 9.4
9999years 14693fd
Start work on GHC 9.4 compat
9999years 1c9498d
Use patched `retrie`
9999years 8b87ce6
update retrie with github address. circumvent nix-prefetch-url.
wavewave 5eca01a
handle ExactPrint
wavewave 0ac3799
fix ghc 9.0 env.
wavewave 2f04bcb
unwrap big CPP conditional for GHC 9.4
wavewave 1617185
GHC 9.4 buildable by disabling a few suggest.. functions
wavewave 04a0f43
enable disabled suggest...!
wavewave dd9b3a1
hls-fourmolu-plugin is buildable
9999years 013217f
hls-splice-plugin is buildable
9999years 3fc6870
hls-hlint-plugin is buildable
9999years 07e3d8e
Enable plugins on GHC 9.4
9999years e6fb469
Add fourmolu for GHC 9.4
9999years 0025609
fourmolu tweawk
9999years 80efb1f
Fix `hls-hlint-plugin` build
Gabriella439 4f6a451
Fix build of `hls-splice-plugin`
Gabriella439 bb863b4
annotation on close parenthesis. still need more work.
wavewave c8334fa
found where closing parenthesis were missing
wavewave 83aef0f
examine internal annotation information.
wavewave cc327a1
make use of makeDeltaAst. This fixes most of test failures in GHC 9.4
wavewave e05ad59
remove dead code
wavewave d9a6509
update apply-refact and hlint deps
wavewave b4511b9
temporarily comment out hls-fourmolu-plugin.
wavewave 24f45d2
comment out build-tool-depends. then hls-fourmolu-plugin build succee…
wavewave fd92fa5
remove unused fourmolu flake inputs
wavewave 49aeb73
fix ghc 9.0 build again.
wavewave 63ba2cb
hlint and fourmolu for GHC 9.2!
wavewave 79a9272
fix mistakenly overriden nix exp.
wavewave 2ab0974
remove unused hlint-3.3.6
wavewave 8a0c4f3
Fix CPP in hls-refactor-plugin
9999years 5b569e2
Fix build error in hls-refactor-plugin
9999years 747e02c
Fix import
9999years c943767
Use `showErrors` instead of `showBag`
9999years 5f492d0
fix initialization test error in refactor plugin.
wavewave e2e3a01
alternateNumberFormat and explicitFixity don't build on GHC 9.4
9999years 5c05d35
force demoteIfDefer = id in typecheckModule for GHC 9.4.
wavewave 9ca95ed
ignore tests which were already ignored with GHC 9.2
wavewave 5f2e77d
fix extractDoesNotExportModuleName for GHC 9.4 by adjusting regex match
wavewave a3647c0
use makeDeltaAst in removeRedundantConstraints
wavewave b38226c
fix addTypeAnnotationsToLiteralsTest
wavewave 765fb9c
Revert "alternateNumberFormat and explicitFixity don't build on GHC 9.4"
9999years 77a097e
Update flake lockfile
9999years c0b4951
Use upstream `retrie`
9999years 87f04c0
Use upstream `retrie`
9999years b7eac4d
Update lockfile
9999years a2e200b
Use upstream fourmolu
9999years 256c55d
fix arrow annotation on ghc 9.4
wavewave 1b5e33f
fix flake.nix issue
wavewave 7af6271
revert demoteIfDefer change for GHC 9.4.
wavewave c2c7461
fix hls-splice-plugin build on GHC 9.0.2
wavewave 5626418
Merge branch 'master' into rebeccat/ghc94-merge
wavewave 0770865
disable tracy on darwin.
wavewave 6730eaf
disable fourmolu plugin and ekg-json for now.
wavewave 0ce9e6d
fourmolu update to 0.10.1.0
wavewave c86a07c
build fix for hls-refactor-plugin after merge
wavewave 1408667
update index-state.
wavewave e7b83bf
downgrade fourmolu to 0.9 for ghc 9.2 and 9.0
wavewave 4a2e757
remove unnecessary problematic Cabal-syntax dependency.
wavewave 9e1fef1
update Cabal for ormolu in ghc 9.0 nix env.
wavewave 665b083
use custom apply-refact for now for both ghc 9.2 and 9.4
wavewave f45a92e
Merge branch 'master' into rebeccat/ghc94
wavewave c757206
added ghc >= 9.2 condition
wavewave 476f168
fix fourmolu with -f-fixity-th in nix env
wavewave cb6b3c1
limit implicit-hie < 0.1.3
wavewave 99de03d
add fourmolu back to build-tools-depends
wavewave 7ab1e11
mark GHC92-failing tests to be failed on GHC 9.4
wavewave 837b040
ci failure test
wavewave 14bbec3
bump nix file.
wavewave ab753ba
disable cachix action
wavewave 299c3c1
further comment out
wavewave 5b98a6e
revive cachix action.
wavewave 4c518f8
remove commented-out
wavewave b3168bb
Merge branch 'wavewave/fourmolu-fix' into wavewave/ci-nix-build
wavewave f6d857a
fix hls-cabal-plugin by removing Cabal-syntax.
wavewave 30dac51
limit implicit-hie < 0.1.3
wavewave f0bcb95
added a small comment and link to the issue.
wavewave 35f328f
Merge branch 'wavewave/fourmolu-fix' into wavewave/ci-nix-build
wavewave 0eab340
Merge branch 'master' into wavewave/ci-nix-build
wavewave 1f6d034
Merge remote-tracking branch 'mercury/wavewave/ci-nix-build' into reb…
wavewave 0557552
put implicit-hie to ghcide dep
wavewave ad2d33a
Merge branch 'wavewave/ci-nix-build' into rebeccat/ghc94
wavewave b4cee21
Merge branch 'master' into rebeccat/ghc94
wavewave 5d3c848
Merge branch 'master' into rebeccat/ghc94
wavewave eac6f1b
update apply-refact rev
wavewave 61aca10
use apply-refact-0.11.0.0 on hackage.
wavewave 425119a
Merge branch 'master' into rebeccat/ghc94
wavewave 65e9f0c
Merge branch 'master' into rebeccat/ghc94
wavewave 7dc9666
Merge remote-tracking branch 'mercury/rebeccat/ghc94' into rebeccat/g…
wavewave 410d0d0
9.4 support for gadt and retrie plugins
wz1000 6408e81
Merge branch 'master' into rebeccat/ghc94
wz1000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a plan for upstreaming this to https://github.com/mpickering/apply-refact ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup. I contacted the maintainers and kept discussing about this directly last few days. Will remove this as the new version is released. thanks.