Extract AddArgument modules #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiweight
force-pushed
the
fixup-add-arg
branch
from
ed362a4 to
1041a25
Compare
michaelpj
approved these changes
Nov 15, 2022
| @@ -2169,220 +2169,21 @@ insertNewDefinitionTests = testGroup "insert new definition actions" | |||
| addFunctionArgumentTests :: TestTree | |||
| addFunctionArgumentTests = | |||
| testGroup | |||
| "add function argument" | |||
| [ testSession "simple" $ do | |||
There was a problem hiding this comment.
Some of these tests seem to have vanished? Is that deliberate/are the new tests equally good?
|
Looks like it has some actual compile errors. |
santiweight
force-pushed
the
fixup-add-arg
branch
from
6eb8a51 to
bfafbeb
Compare
|
Now builds on 9.2.4 and 8.10.7. I'll let CI tell me about the other versions... |
santiweight
force-pushed
the
fixup-add-arg
branch
from
bfafbeb to
fae8f37
Compare
|
There was some flakey test in call-hierarchy on Ubuntu; I reran and it worked. So I'm going to try to merge now... |
|
Looks like an erroneous failure to me? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor which starts the end of the oversized modules in hls-refactor-plugin.
@pepeiborra and @michaelpj both raised this during review.
Reviewing commit-by-commit will be easier for you