Skip to content

Enable plugin tests in CI for GHC 9.4 #3420

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Enable plugin tests in CI for GHC 9.4 #3420

merged 3 commits into from
Dec 22, 2022

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Dec 21, 2022

We neglected to enable testing in CI of all the newly patched plugins for GHC 9.4

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this!

@wz1000 wz1000 force-pushed the wip/fix-9.4-tests branch 2 times, most recently from b792d64 to f6019b3 Compare December 21, 2022 22:58
@michaelpj
Copy link
Collaborator

Oof, good catch!

@mpickering
Copy link
Contributor

Good work Zubin.

Copy link
Collaborator

@konn konn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! 👍

@wz1000 wz1000 added the merge me Label to trigger pull request merge label Dec 22, 2022
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit e7b1ef0 into master Dec 22, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants