Experiment with loading matrix values from a file #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
force-pushed
the
mpj/dynamic-matrices
branch
2 times, most recently
from
fbb432e to
1c746c2
Compare
michaelpj
commented
Feb 8, 2023
| os: [ubuntu-latest] | ||
| ghc: | ||
| - '8.10.7' | ||
| - '9.2.5' |
There was a problem hiding this comment.
I'm unsure what to do here.
- Benchmark on all GHC versions, why not?
- Benchmark on GHC versions determined by some rule, e.g. the latest two versions?
- Benchmark on some specific named versions
cc @pepeiborra
There was a problem hiding this comment.
We don't do automated regression analysis on benchmark results, so it doesn't really matter much. Benchmark on each ghc major version latest minor would be reasonable
There was a problem hiding this comment.
Okay, I'll add a note but I don't want to get into JSON processing right now :D
|
Seems to work, and ensures that the jobs can't get out of sync any more! |
fendor
approved these changes
Feb 13, 2023
The goal here is to avoid duplication of e.g. which versions of GHC we support. This is an experiment at the moment.
michaelpj
force-pushed
the
mpj/dynamic-matrices
branch
from
1c746c2 to
d4f69e2
Compare
michaelpj
force-pushed
the
mpj/dynamic-matrices
branch
from
d4f69e2 to
bd8e6a0
Compare
wz1000
pushed a commit
that referenced
this pull request
Mar 14, 2023
* Experiment with loading matrix values from a file The goal here is to avoid duplication of e.g. which versions of GHC we support. This is an experiment at the moment. * fix some warnings in hlint plugin
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to avoid duplication of e.g. which versions of GHC we
support.
This is an experiment at the moment.