Simplify selection of GHCs to build on #3633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The haskell setup action supports using the major version, and then it will select the latest minor version. That should be fine for us - we don't have to change anything to get new minor versions, and it's not too much of a problem to get new minor versions implicitly, since they should be very unlikely to break things.
michaelpj
force-pushed
the
mpj/ghc-major-versions
branch
3 times, most recently
from
98aff46 to
f07c2ff
Compare
michaelpj
force-pushed
the
mpj/ghc-major-versions
branch
from
8b848e2 to
d3954ce
Compare
|
Then the minor version we install depends on the setup action version? |
|
Yep. Which I think is fine? We'll still discover any issues deterministically when that gets updated. |
fendor
approved these changes
Jun 11, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The haskell setup action supports using the major version, and then it
will select the latest minor version. That should be fine for us - we
don't have to change anything to get new minor versions, and it's not
too much of a problem to get new minor versions implicitly, since they
should be very unlikely to break things.