Add an assist for importing record fields when using OverloadedRecordDot #3642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
requested changes
Jun 10, 2023
Yup, I'll give it a check tomorrow |
simmsb
force-pushed
the
master
branch
2 times, most recently
from
2867a34 to
457e2ac
Compare
|
stylish-haskell failed in pre-commit, weirdly? |
Probably due to cpp stuff. Some of the cpp tags especially for ghc >=9.5 poison stylish-haskell. I think it's usually possible to format cpp that stylish-haskell can accept usually at the cost of brevity, but once there is a poisonous cpp in a file you edit you can either change it yourself and add a bunch of lines to your diff, or commit with --no-verify |
simmsb
force-pushed
the
master
branch
2 times, most recently
from
a45a73d to
a1cc6a2
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using OverloadedRecordDot to access fields of a record, if the field being accessed is not imported then a constraint error will be emitted.
In ghc 9.6 the error message carries a suggestion to import the field (and so the assist will be generated), however in ghc 9.2 this suggestion is not present and so we don't get any assist.