GHC 9.8 support #3727
Merged
GHC 9.8 support #3727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
requested review from
pepeiborra,
joyfulmantis,
ozkutuk,
Ailrun,
konn,
kokobd,
santiweight,
OliverMadine,
eddiemundo,
berberman,
July541,
georgefst,
VeryMilkyJoe,
fendor and
drsooch
as code owners
wz1000
force-pushed
the
wip/ghc-9.8
branch
2 times, most recently
from
84e7d80 to
364eb95
Compare
|
All non exactprint plugins work and tests pass locally. I've added a CI job to test against 9.8-rc1. |
wz1000
force-pushed
the
wip/ghc-9.8
branch
6 times, most recently
from
366ecb1 to
6aa2a66
Compare
michaelpj
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Looks reasonable. Maybe @joyfulmantis as the CPP sherrif wants to take a look at the CPP.
| deepseq, | ||
|
|
||
| if impl(ghc >= 9.7) | ||
| repository head.hackage.ghc.haskell.org |
There was a problem hiding this comment.
I guess we can't really avoid this at the moment? I'm unsure how I feel about the prospect of us e.g. releasing binaries based on using packages from head.hackage 🤔 maybe it's fine
There was a problem hiding this comment.
No. I could use git dependencies instead by pushing head.hackage patches to forks, but I don't think it earns us much.
| 26021a13b401500c8eb2761ca95c61f2d625bfef951b939a8124ed12ecf07329 | ||
| 7541f32a4ccca4f97aea3b22f5e593ba2c0267546016b992dfadcd2fe944e55d | ||
|
|
||
| active-repositories: hackage.haskell.org, head.hackage.ghc.haskell.org |
There was a problem hiding this comment.
I think you don't need this
plugins/hls-alternate-number-format-plugin/src/Ide/Plugin/Literals.hs
Outdated
Show resolved
Hide resolved
|
Incidentally, can we delete the allow-newers for older GHC versions now? |
fendor
approved these changes
Oct 6, 2023
wz1000
force-pushed
the
wip/ghc-9.8
branch
2 times, most recently
from
6d3635c to
6d22882
Compare
wz1000
force-pushed
the
wip/ghc-9.8
branch
3 times, most recently
from
2af067b to
10549ff
Compare
Requires head.hackage to build
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires head.hackage to build
Support for ghcide + non-exactprint plugins.