Skip to content

Change refine imports behaviour for qualified imports #3806

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Sep 20, 2023

Conversation

joyfulmantis
Copy link
Collaborator

@joyfulmantis joyfulmantis commented Sep 14, 2023

This PR addresses issue #3770, specifically, it implements option 2 "If an import is qualified, refine it and keep the same qualification, but don't give it an explicit import list."

@joyfulmantis joyfulmantis changed the title Change refine imports behavior for qualified imports Change refine imports behaviour for qualified imports Sep 14, 2023
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about whether the bug even happens!

Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the direction of travel, just one more potential simplification.

@joyfulmantis joyfulmantis enabled auto-merge (squash) September 19, 2023 14:41
@joyfulmantis joyfulmantis merged commit f14e5a6 into haskell:master Sep 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants