Skip to content

Update base lower bounds for HLS #4000

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2024
Merged

Update base lower bounds for HLS #4000

merged 2 commits into from
Jan 22, 2024

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Jan 21, 2024

Fix #3999

@fendor fendor requested a review from pepeiborra as a code owner January 21, 2024 09:09
@fendor fendor force-pushed the enhance/hls-base-bounds branch from 4bf7954 to ef28f62 Compare January 21, 2024 09:20
@fendor fendor requested a review from michaelpj January 21, 2024 09:27
michaelpj
michaelpj approved these changes Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. I think the thing that actually caused the compile errors was the ghc package, though, and I think it probably makes sense to bound our uses of that too to reflect the GHC's we support?

@fendor
Copy link
Collaborator Author

fendor commented Jan 21, 2024

I think it probably makes sense to bound our uses of that too to reflect the GHC's we support?

That's true, bumping the lower bound for ghc as well.

@fendor fendor force-pushed the enhance/hls-base-bounds branch from aaed18c to 9ca834d Compare January 21, 2024 21:05
@fendor fendor enabled auto-merge (squash) January 21, 2024 21:05
@fendor fendor merged commit be31326 into haskell:master Jan 22, 2024
josephsumabat pushed a commit to josephsumabat/haskell-language-server that referenced this pull request Jan 22, 2024
@fendor @josephsumabat
Update base lower bounds for HLS (haskell#4000)
4b70196 
* Update base lower bounds for HLS

* Bump lower bound
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hasufell hasufell hasufell approved these changes

@michaelpj michaelpj michaelpj approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base lower bounds are wrong
3 participants
@fendor @hasufell @michaelpj