Skip to content

Fix -Wall and -Wunused-packages in stan plugin #4014

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Jan 24, 2024

This PR is part of larger effort where I try to reduce the amount of compiler warnings across all packages.

@jhrcek jhrcek requested a review from 0rphee as a code owner January 24, 2024 06:24
@michaelpj
Copy link
Collaborator

Sounds like there are some genuine questions, perhaps @0rphee can advise.

@0rphee
Copy link
Collaborator

0rphee commented Jan 25, 2024

Everything seems fine. Some errors seem to have eluded me!

@jhrcek jhrcek force-pushed the jhrcek/unused-packages-stan branch from 41b4ce0 to f594d5e Compare January 26, 2024 04:14
@jhrcek
Copy link
Collaborator Author

jhrcek commented Jan 26, 2024

@0rphee thanks for checking. @michaelpj This PR should be merge-ready.

@michaelpj michaelpj enabled auto-merge (squash) January 26, 2024 11:32
@jhrcek jhrcek force-pushed the jhrcek/unused-packages-stan branch from 24d3ff1 to 9a526a5 Compare February 2, 2024 06:34
@michaelpj michaelpj merged commit a0baa4d into haskell:master Feb 2, 2024
@jhrcek jhrcek deleted the jhrcek/unused-packages-stan branch February 12, 2024 09:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants