Skip to content

Turn off tasty-rerun #4028

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 9 commits into from
Feb 1, 2024
Merged

Turn off tasty-rerun #4028

merged 9 commits into from
Feb 1, 2024

Conversation

michaelpj
Copy link
Collaborator

No description provided.

@michaelpj michaelpj requested a review from fendor as a code owner January 30, 2024 16:21
@Bodigrim
Copy link
Contributor

I think tasty-rerun is doing what it's asked for, no? It's just that cabal test ghcide --test-options="$TEST_OPTS" || cabal test ghcide --test-options="$TEST_OPTS" is a very strange pattern, especially given that rerun logs are cached.

@jhrcek
Copy link
Collaborator

jhrcek commented Jan 31, 2024

I was surprised by this too.
Given that caching is involved, my expectation would be to do
--rerun-update only is used in the first run (so that all tests are executed no matter what other branches have chached)
--rerun-filter filters,exceptions is used in the second run.

@michaelpj
Copy link
Collaborator Author

Yes, this certainly interacts with our slightly idiosyncractic approach to re-running tests. For now I'm just trying to clear the deck so we can get everything green again!

@michaelpj michaelpj force-pushed the mpj/turn-off-tasty-rerun branch from b6f0d28 to 111c040 Compare January 31, 2024 13:51
@michaelpj
Copy link
Collaborator Author

Somehow, inexplicably, that seems to have got us back to a better place. Could it be that somehow those ghcide tests only pass when run by themselves, which accidentally happens if they fail and then get rerun?

@michaelpj michaelpj enabled auto-merge (squash) January 31, 2024 18:41
@michaelpj
Copy link
Collaborator Author

I don't fully understand, but I think I've restored us to the old state, so I'm going to try and merge this to keep us green.

@michaelpj michaelpj merged commit 90eed1a into master Feb 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants