Skip to content

[Migrate AsyncTests] part of 4173 Migrate ghcide tests to hls test utils #4199

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2024
Merged

[Migrate AsyncTests] part of 4173 Migrate ghcide tests to hls test utils #4199

merged 2 commits into from
May 1, 2024

Conversation

soulomoon
Copy link
Collaborator

No description provided.

@soulomoon soulomoon mentioned this pull request Apr 30, 2024
Closed
31 tasks
@soulomoon soulomoon changed the title migrate AsyncTests to hls-test-utils [Migrate AsyncTests] part of 4173 Migrate ghcide tests to hls test utils Apr 30, 2024
@soulomoon soulomoon marked this pull request as ready for review April 30, 2024 23:04
@soulomoon soulomoon requested a review from pepeiborra as a code owner April 30, 2024 23:04
fendor
fendor approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@soulomoon
Copy link
Collaborator Author

Thanks for the review

@soulomoon soulomoon merged commit 0e52d91 into haskell:master May 1, 2024
35 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fendor fendor fendor approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soulomoon @fendor