Skip to content

convert pre-commit-config.yaml from JSON to YAML #4513

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

peterbecich
Copy link
Member

@peterbecich peterbecich commented Mar 10, 2025

using https://www.geeksforgeeks.org/json-to-yaml-converter/ .

The new YAML configuration appears to be fine:

$ pre-commit run --all-files
stylish-haskell..........................................................Passed
mixed line ending........................................................Passed

This matches the standard YAML config of the tool: https://pre-commit.com/#installation


However, I am not certain .pre-commit-config.yaml is working as intended, on master or this PR. Can I fix this in a separate PR?

After putting some spaces into Experiments.hs

module Experiments
( Bench(..)
, BenchRun(..)
, Config(..)


, Verbosity(..)
...
import           Data.Either                        (fromRight)

import           Data.List
import           Data.Maybe
...
$ pre-commit run --all-files
stylish-haskell..........................................................Passed
mixed line ending........................................................Passed

pre-commit succeeds on master branch with the JSON configuration.

@peterbecich peterbecich changed the title convert pre-commit-config from JSON to YAML convert pre-commit-config.yaml from JSON to YAML Mar 10, 2025
@peterbecich peterbecich requested a review from soulomoon March 10, 2025 06:57
@peterbecich peterbecich enabled auto-merge (squash) March 10, 2025 08:14
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't have any strong feelings here, since I am not using the pre-commit hook any way 🙊

@peterbecich peterbecich merged commit 682d689 into haskell:master Mar 10, 2025
37 checks passed
@peterbecich peterbecich deleted the pre-commit-hook branch March 10, 2025 19:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants