porting hls-refactor to ghc-9.12

[GuillaumedeVolpiano]

These changes allow the hls-refactor plugin to compile and pass the tests with ghc-9.12

[fendor]

LGTM, amazing work!
I have honestly not reviewed in-depth. I will rely on the test-suite to catch any mistakes :)

[fendor]

The tests will not run on CI, you need to change this line: https://github.com/haskell/haskell-language-server/blob/master/.github/workflows/test.yml#L137

Very difficult to find, apologies!

Also, just making sure, you can ignore the pre-commit error in CI.

[GuillaumedeVolpiano]

Changed. Hadn't even thought to look there. Hopefully they will run smoothly. Thanks for pointing it out.

[GuillaumedeVolpiano]

Let's make sure this is fine, but I just wanted to note that as a consequence, rename and splice built smoothly on my end, they'll just need unmasking afterwards. Unless you want me to add it here. gadt will need some love, on the other hand.

[fendor]

It is fine to enable more plugins immediately, spares us a separate CI run :)

You have to accept the changes to the golden files, this is just there so we are sure to catch the changes!

[GuillaumedeVolpiano]

OK. Hold a bit then, because I see that splice is currently <ghc-9.10. I need to check it with ghc-9.10 too

[fendor]

No hurry, I will be here tomorrow as well :D CI will take a while anyway.

[GuillaumedeVolpiano]

Tests pass on my side. Let's see how the CI goes.

[GuillaumedeVolpiano]

I might need help understanding these failing ghcide tests. They don't seem to relate to any of my changes…

[fendor]

The windows CI failures are spurious and will be resolved by simply rerunning CI (which I will take care of). The 9.12. ubuntu failure is genuine, as you are enabling plugins, you need to accept the test changes.

[GuillaumedeVolpiano]

So basically I need to patch the test file as indicated by the results of the test, do I understand this right? Sorry if it's a dumb question, it's my first time running into these.

[fendor]

Yes, this should do the trick: https://github.com/haskell/haskell-language-server/blob/master/test/functional/ConfigSchema.hs#L20

Assuming, you run the test with ghc-9.12.2. Also, not a dumb question, maybe we can add some explanations to the test failure to make this easier to discover.

[GuillaumedeVolpiano]

Now that was easy. Thanks for the pointer

[GuillaumedeVolpiano]

Well, seems I actually failed a few tests.will get back to work on it. Sorry about that

[fendor]

Don't worry, we are very happy you are working on it :)

[GuillaumedeVolpiano]

Thanks. Maybe worth adding a WIP tag to it for now?

[fendor]

Like this?

[GuillaumedeVolpiano]

Yes thanks!

[GuillaumedeVolpiano]

Only two tests left. Of course, the first four were easy because they're actually just changes in the way ghc report things.

[GuillaumedeVolpiano]

Five downs, one to go

[GuillaumedeVolpiano]

@fendor : We're good to go

[fendor]

Amazing work, only two small comments, then we will merge!

Thank you for this great contribution :)

[GuillaumedeVolpiano]

I'm going to re-disable splice. I'll look at it and gadt in a second time.

[GuillaumedeVolpiano]

@fendor : can you have a look at the failures? I think they are of the spurious kind, but if they're not, I'll also disable rename for now and add it to my todo list ;)

[fendor]

Yeah, they look spurious. I will rerun the CI job once the others have finished running.

[fendor]

Awesome! There will be likely another release in the next two weeks, our users will be happy to see the refactor plugin enabled for GHC 9.12.2 :)

[GuillaumedeVolpiano]

Thanks for accepting my PR. Will do my best to add a few other plugins in the meantime :p