-
-
Notifications
You must be signed in to change notification settings - Fork 394
Enable stylish-haskell for ghc-9.10 and ghc-9.12 #4559
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Enable stylish-haskell for ghc-9.10 and ghc-9.12 #4559
Conversation
@fendor : I guess the tests will need to be rerun later, cabal is failing to find stylish-haskell-0.15.0.0, which was added to hackage yesterday… |
7f104ec
to
d35e346
Compare
plugins/hls-stylish-haskell-plugin/src/Ide/Plugin/StylishHaskell.hs
Outdated
Show resolved
Hide resolved
@GuillaumedeVolpiano You have to update the |
011e927
to
d1d9db9
Compare
@jhrcek : stylish-haskell now needs Cabal-3.14, but this conflicts with a lot of things here. I can get stylish-haskell to compile nicely with Cabal-3.12 with the following changes to lib/Language/Haskell/Stylish/Config/Cabal.hs
#else
#endif` But I guess this kindof defeats your purpose. If not, I'll submit a PR there, hopefully we get a 0.15.0.1 version and everything will be simple then. @fendor : I guess we need a Draft label here for now. |
d1d9db9
to
f82fc31
Compare
Oh, that's not good. I guess that Jasper proactively bumped to the latest version of cabal syntax in haskell/stylish-haskell#489 before merging my 9.10 support PR. I wonder if we could broaden the accepted version range of stylish-haskell's Cabal dependency (not really sure how Cabal stuff is used in stylish-haskell)? |
dce2c11
to
1d324d6
Compare
1d324d6
to
b1b4524
Compare
@fendor @michaelpj @jhrcek : this is now ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! When can we drop support for stylish-haskell 0.14? Like, which ghc version is only compatible with the older stylish-haskell version?
9.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, including pushing the work on upstream dependencies 👍
With the release of stylish-haskell-0.15.0.0, it now builds with ghc-lib-parser-9.10, so we can enable the plugin for ghc-9.10.
Note that a ghc-lib-parser-9.12 version should be released soon.