Skip to content

Fix misplaced inlay hints by applying PositionMapping #4571

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 27, 2025

Conversation

jetjinser
Copy link
Contributor

resolve #4561.

fixed hls-explicit-imports-plugin, hls-explicit-record-fields-plugin.

@jetjinser jetjinser requested a review from ozkutuk as a code owner April 25, 2025 07:48
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't check this works correctly now, and I am not sure whether we even could add a test for this that isn't incredibly flaky.

@fendor fendor enabled auto-merge (rebase) April 25, 2025 08:09
auto-merge was automatically disabled April 25, 2025 08:25

Head branch was pushed to by a user without write access

@fendor fendor merged commit 173b5a7 into haskell:master Apr 27, 2025
41 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inlay Hints for imports seem to be misplaced
2 participants