Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Delete duplicate cabal clause for applyrefact2 #654

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Delete duplicate cabal clause for applyrefact2 #654

merged 4 commits into from
Dec 9, 2020

Conversation

peterwicksstringfield
Copy link
Contributor

@peterwicksstringfield peterwicksstringfield commented Dec 8, 2020 •
edited
Loading

The other copy of this clause is a few lines above the one I deleted.

@jneira
Copy link
Member

jneira commented Dec 8, 2020 •
edited
Loading

wow, i didnt notice ApplyRefact2 was listed here, thanks for catching up
In fact i think we could remove all ocurrences, as hlint tests are using a direct hie.yaml and hls does not look in parent dirs.

@peterwicksstringfield
Delete extraneous cabal clause for ApplyRefact2.hs.
66aacfd 
This test uses a direct hie.yaml and this cabal file is not inspected, so this
clause does nothing.
@peterwicksstringfield
Delete extraneous cabal clause for non-existent ApplyRefact.hs.
099e89e
@peterwicksstringfield
Copy link
Contributor Author

I think you are right. Also apparently ApplyRefact.hs doesn't exist anymore so we can lose that clause too.

test/testdata/HlintPragma.hs and test/testdata/FileWithWarning.hs are currently unused in the tests, so I guess those clauses are sort of useless too. All the HaRe stuff too.

@jneira
Copy link
Member

jneira commented Dec 8, 2020

test/testdata/HlintPragma.hs and test/testdata/FileWithWarning.hs are currently unused in the tests, so I guess those clauses are sort of useless too. All the HaRe stuff too.

yeah, please, clean them too if you dont mind make the pr larger

@jneira
Copy link
Member

jneira commented Dec 9, 2020

Well, let's move this forward, the full clean could be in another pr

@jneira jneira merged commit fc1ae15 into haskell:master Dec 9, 2020
@peterwicksstringfield peterwicksstringfield deleted the delete_duplicate_cabal_clause branch December 9, 2020 15:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterwicksstringfield @jneira