V1: Add an instance for the new SeedGen type class #96
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/add-random-seed-instance
branch
2 times, most recently
from
998989a to
12d6e48
Compare
lehins
force-pushed
the
lehins/add-random-seed-instance
branch
from
12d6e48 to
9bdbc18
Compare
lehins
changed the title
lehins
changed the title
|
@lehins Thank you for your work! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first potential version, while the second version is in #98
This version is faster, since it does not have to rely on intermediate list structure and utilizes some of the
vectorunsafe functionality to achieve that. It also requires a newer version ofvecotr, since it was only invector-0.10.12that constructor for primitiveVectorwas exported.The down side of this approach is that a seed that is stored on a big endian machine will not read the same on a little endian machine and vise versa. This is not a problem for the approach take n #98