Skip to content

Upgrade to ghc 9.12 #491

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Apr 18, 2025
Merged

Upgrade to ghc 9.12 #491

merged 3 commits into from
Apr 18, 2025

Conversation

GuillaumedeVolpiano
Copy link
Contributor

@GuillaumedeVolpiano GuillaumedeVolpiano commented Apr 6, 2025

Building on #480, this makes stylish-haskell functionally complete for ghc-9.12. Only one failing test left.

@Miezhiko
Copy link
Contributor

Miezhiko commented Apr 7, 2025

tested with my setup it works \o/ thank you

@GuillaumedeVolpiano
Copy link
Contributor Author

tested with my setup it works \o/ thank you

Nearly. There is a niche issue when you have a comment between the data declaration and the first constructor.

@GuillaumedeVolpiano
Copy link
Contributor Author

@Miezhiko Ignore my previous comment. All tests pass. Insert victory danse here.

@GuillaumedeVolpiano GuillaumedeVolpiano changed the title Upgrade to Ghc9.12 Upgrade to ghc 9.12 Apr 7, 2025
@GuillaumedeVolpiano GuillaumedeVolpiano force-pushed the ghc9.12 branch 4 times, most recently from 52f9622 to bace5b7 Compare April 13, 2025 10:32
@GuillaumedeVolpiano
Copy link
Contributor Author

@jaspervdj : this should be ready for review.
@jhrcek : happy to take any suggestions you might have.

@jaspervdj
Copy link
Member

@GuillaumedeVolpiano Thanks a lot! I will cut a release (v0.15.0.0) from main before merging this in.

Copy link
Contributor

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great.
Just a small suggestion.

Copy link
Member

@jaspervdj jaspervdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@GuillaumedeVolpiano
Copy link
Contributor Author

I had removed Data.List.foldl' from the imports of SimpleAlign, turns out ghc 9.8 still needs it, so I brought it back

@GuillaumedeVolpiano
Copy link
Contributor Author

Oh, so we're hitting the same bug with ghc-lib-parser-9.12 and ghc-9.8 that I'm hitting on Gentoo.

digital-asset/ghc-lib#595

Shall we just limit the versions to ghc-9.10 and ghc-9.12 until ghc-lib makes a release fixing this? I'll see if I can patch it, but it might take time to get to release. What do you think?

@jaspervdj
Copy link
Member

Okay, yeah, I think limiting it is fine given that we just made a release supporting ghc-9.6 and ghc-9.8.

@GuillaumedeVolpiano
Copy link
Contributor Author

Done

@GuillaumedeVolpiano GuillaumedeVolpiano force-pushed the ghc9.12 branch 2 times, most recently from 6f7a753 to 77017f4 Compare April 15, 2025 14:13
@Mikolaj
Copy link
Member

Mikolaj commented Apr 16, 2025

Well done!

@jaspervdj jaspervdj mentioned this pull request Apr 18, 2025
@jaspervdj jaspervdj merged commit 6dac2fa into haskell:main Apr 18, 2025
5 checks passed
@jaspervdj
Copy link
Member

Released as v0.15.1.0 -- thanks a lot @GuillaumedeVolpiano!

@GuillaumedeVolpiano
Copy link
Contributor Author

Also the issue with ghc-lib-parser should be fixed soon

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants