-
Notifications
You must be signed in to change notification settings - Fork 152
Upgrade to ghc 9.12 #491
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade to ghc 9.12 #491
Conversation
cf3a821
to
d6f4184
Compare
b78c138
to
2e0e410
Compare
tested with my setup it works \o/ thank you |
Nearly. There is a niche issue when you have a comment between the data declaration and the first constructor. |
2e0e410
to
c4bcd1d
Compare
@Miezhiko Ignore my previous comment. All tests pass. Insert victory danse here. |
52f9622
to
bace5b7
Compare
@jaspervdj : this should be ready for review. |
@GuillaumedeVolpiano Thanks a lot! I will cut a release (v0.15.0.0) from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks great.
Just a small suggestion.
bace5b7
to
21eb8c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
21eb8c9
to
8d740a2
Compare
I had removed Data.List.foldl' from the imports of SimpleAlign, turns out ghc 9.8 still needs it, so I brought it back |
Oh, so we're hitting the same bug with ghc-lib-parser-9.12 and ghc-9.8 that I'm hitting on Gentoo. Shall we just limit the versions to ghc-9.10 and ghc-9.12 until ghc-lib makes a release fixing this? I'll see if I can patch it, but it might take time to get to release. What do you think? |
Okay, yeah, I think limiting it is fine given that we just made a release supporting ghc-9.6 and ghc-9.8. |
8d740a2
to
8e3334b
Compare
Done |
6f7a753
to
77017f4
Compare
77017f4
to
1bbf21c
Compare
Well done! |
Released as v0.15.1.0 -- thanks a lot @GuillaumedeVolpiano! |
Also the issue with ghc-lib-parser should be fixed soon |
Building on #480, this makes stylish-haskell functionally complete for ghc-9.12. Only one failing test left.