Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump dependencies (support ghc 9.12) #624

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

erikd
Copy link
Member

@erikd erikd commented Dec 3, 2024

ghc-9.12 is not yet available in CI.

@phadej
Copy link
Contributor

phadej commented Dec 3, 2024

ghc-9.12 is not yet available in CI.

It is, for quite a while.

@erikd
Copy link
Member Author

erikd commented Dec 3, 2024

It is, for quite a while.

I was incorrectly using 9.12.0 instead of 9.12.1 🤷

@erikd erikd force-pushed the master branch 2 times, most recently from ef11d47 to 42d1aa9 Compare December 3, 2024 18:59
- compiler: ghc-9.12.0.20241114
compilerKind: ghc
compilerVersion: 9.12.0.20241114
setup-method: ghcup
Copy link
Contributor

@phadej phadej Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is due

ghcup-jobs: >=8.2

in cabal.haskell-ci. haskell-ci tries to use the default ghcup channel for 9.12 versions too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That configuration field should be removed. It's more harmful than useful.

@erikd erikd force-pushed the master branch 2 times, most recently from d8494b0 to ea1a42e Compare December 3, 2024 19:34
@Bodigrim
Copy link
Contributor

Bodigrim commented Dec 3, 2024

I raised https://gitlab.haskell.org/ghc/ghc/-/issues/25548 to clarify whether bumping ghc-prim from 0.11 to 0.13 was intentional.

cabal.project Outdated

allow-newer:
, splitmix:base
, tasty-inspection-testing:base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep cabal.project unchanged please: these allow-newer tend to fossilize and then no one remembers which version of GHC they are for. Besides, tasty-inspection-testing has been bumped already and I imagine splitmix will follow the suite soon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the allowed-newer for tasty-inspection-testing and bracketed it with if impl (ghc >= 9.12)

@Bodigrim
Copy link
Contributor

@erikd may I ask you to update it once more? Please use the latest haskell-ci so that generated script uses GHC 9.12.1 proper. And there is no longer a need for allow-newer I believe.

@pgujjula pgujjula mentioned this pull request Dec 30, 2024
3 tasks
@Bodigrim Bodigrim merged commit a721bf5 into haskell:master Jan 6, 2025
25 of 26 checks passed
@Bodigrim
Copy link
Contributor

Bodigrim commented Jan 6, 2025

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants