Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix wrapper call to get project ghc version in windows and spaces in path #439

Merged
merged 2 commits into from
Aug 25, 2021
+6 −6
Merged

Fix wrapper call to get project ghc version in windows and spaces in path #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72e5678
Quote the wrapper
jneira Aug 15, 2021
bedf3b8
Bump up version to 1.6.1
jneira Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "haskell",
"displayName": "Haskell",
"description": "Haskell language support powered by the Haskell Language Server",
"version": "1.6.0",
"version": "1.6.1",
"license": "MIT",
"publisher": "haskell",
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion src/hlsBinaries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ async function getProjectGhcVersion(
// We execute the command in a shell for windows, to allow use .cmd or .bat scripts
const childProcess = child_process
.execFile(
wrapper,
getGithubOS() === 'Windows' ? `"${wrapper}"` : wrapper,
args,
{ encoding: 'utf8', cwd: dir, shell: getGithubOS() === 'Windows' },
(err, stdout, stderr) => {
Expand Down