Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #224 #225

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fix #224 #225

merged 2 commits into from
Dec 4, 2023

Conversation

BinderDavid
Copy link
Contributor

@BinderDavid BinderDavid commented Nov 28, 2023

Fixes #224

  • Remove unused imports which lead to warnings (and errors with -Werror)
  • Add a filepath < 1.5 upper bound to the cabal file. (Edit: Changed upper bound to 1.4.200 which added a lot of deprecation warnings which fail with -Werror)
  • Minor fix to the cabal file: cabal-version should be first field; changelog.md should be extra-doc-file.

This hopefully fixes the CI.

@BinderDavid
Copy link
Contributor Author

On appveyor the build runs through again for GHC 9.0. Let's see about the older GHC versions.

@Mistuke I can't see the teamcity logs, so I do not see why they are failing.

@BinderDavid
Copy link
Contributor Author

The first appveyor build which is failing is for a 32-bit platform. In light of https://gitlab.haskell.org/ghc/ghc/-/issues/18487 maybe we could just drop all 32-bit platforms from CI, since GHC is not supporting them anymore?

@hasufell hasufell requested a review from Mistuke November 28, 2023 14:33
@Mistuke
Copy link
Contributor

Mistuke commented Nov 28, 2023

Hi, thanks for the PRs. I'm traveling till Friday and will review then. Don't worry about the CI. I was planning to rework things after my work deadlines.

@Mistuke
Copy link
Contributor

Mistuke commented Dec 4, 2023

would you mind rebasing this @BinderDavid

@BinderDavid
Copy link
Contributor Author

would you mind rebasing this @BinderDavid

Done.

@Mistuke
Copy link
Contributor

Mistuke commented Dec 4, 2023

Thanks!

@Mistuke Mistuke merged commit 354b79c into haskell:master Dec 4, 2023
@Mistuke
Copy link
Contributor

Mistuke commented Dec 4, 2023

I've already revised the version on hackage btw, and will release this one tomorrow morning. Need to update the CI release pipeline.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#221 Introduced unused-imports warnings which lead to failures in GHC
3 participants