Improved logging for store copy / Updated store info to handle multi-arch images #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Martin <adam.martin@rancherfederal.com>
Signed-off-by: Adam Martin <adam.martin@rancherfederal.com>
dweomer
reviewed
Dec 14, 2023
| @@ -4,8 +4,9 @@ import ( | |||
| "context" | |||
| "encoding/json" | |||
| "fmt" | |||
| "strings" | |||
| "text/tabwriter" | |||
| "github.com/olekukonko/tablewriter" | |||
There was a problem hiding this comment.
I'm a fan of his tablewriter. I've used it in a few projects now.
dweomer
reviewed
Dec 14, 2023
| if i != emptyItem { | ||
| items = append(items, i) | ||
| // handle multi-arch images | ||
| if desc.MediaType == consts.OCIImageIndexSchema || desc.MediaType == consts.DockerManifestListSchema2 { |
There was a problem hiding this comment.
I imagine that these media type comparisons/checks will be with us for some years. I wonder if longer term than this particular change-set if it makes sense to unify them conceptually? i.e. for this one, possibly something like hauler.IsImageIndex() / hauler.IsImageShema()
There was a problem hiding this comment.
I like that idea.
There was a problem hiding this comment.
The idea isn't for saving characters/lines of code so much as conceptual concision.
dweomer
approved these changes
Dec 14, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check below, if the PR fulfills these requirements:
What kind of change does this PR introduce?
What is the current behavior?
hauler store copyprovides no incremental feedback.hauler store infois missing data for the majority of images.What is the new behavior (if this is a feature change)?
hauler store copyprovides better logging.hauler store infonow handles multi-arch images.Does this PR introduce a breaking change?
Other information: