Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix for validating foreign blobs #149

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

amartin120
Copy link
Contributor

Please check below, if the PR fulfills these requirements:

  • The commit message follows the guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

What kind of change does this PR introduce?
Added additional configuration to hauler store serve to allow certain layers when starting the registry.

What is the current behavior?

  • If you have images in your hauler store with a layer of type application/vnd.docker.image.rootfs.foreign.diff.tar.gzip (usually with windows arch images), the registry fails to start.
multiple errors returned: UNKNOWN: unknown error; UNKNOWN: unknown error; map[]; MANIFEST_BLOB_UNKNOWN: blob unknown to registry;

What is the new behavior (if this is a feature change)?

  • registry validates the layer and starts up normally.

Does this PR introduce a breaking change?

Other information:

Signed-off-by: Adam Martin <adam.martin@rancherfederal.com>
@amartin120
Copy link
Contributor Author

example image tested is rancher/system-agent-installer-rke2:v1.24.13-rke2r1

@amartin120 amartin120 requested a review from dweomer December 18, 2023 20:37
@amartin120 amartin120 merged commit 8cfe443 into hauler-dev:main Dec 18, 2023
1 check passed
@amartin120 amartin120 deleted the registry-serve-fix branch December 18, 2023 20:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants