Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Layout fixes #1

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Layout fixes #1

wants to merge 6 commits into from

Conversation

mariobuikhuizen
Copy link
Contributor

No description provided.

@havok2063
Copy link
Owner

@mariobuikhuizen I realized I forgot a use case. See index_dynamic.html. It won't make much difference I think to the CSS fixes but it's an example of a page where we send a request to the notebook and dynamically load the Jdaviz application. This was the original reason behind putting the Jdaviz app inside a v.Col since we couldn't add an event_handler directly to the Jdaviz app. Maybe you can fold this example into your CSS tweaks to make it look nice? I tried swapping the v.Col or a generic v.Container, and that mostly worked, but it added some padding that maybe we can avoid?

@havok2063
Copy link
Owner

@mariobuikhuizen Also, the vuetify 2.2.26 is fairly old at this moment. The latest version is 2.4.9. Do you have a version of your hacked package for any later version of Vuetify?

@mariobuikhuizen mariobuikhuizen mentioned this pull request Apr 13, 2021
Merged
@mariobuikhuizen
fix: jdaviz-widget is rendered below the left menu
7749151
@mariobuikhuizen
docs: open htmls directly instead copying to index.html
57a2f82
@mariobuikhuizen
fix: missing icons
44471ba
@mariobuikhuizen
fix: menu under cog icon appears offset to the right
f42a9b3 
Vuetify expects to be alone on the page with a top level v-app
component. Since this is not the case in zmast.html we use a
modified version of Vuetify that works around this. This is the
same package used in ipyvuetify in the notebook, since that
environment has the same issue.

This also prevents a lot of style conflicts between Vuetify and
Bootstrap.
@mariobuikhuizen
fix: control the height of the jdaviz app
dcd3dda 
Depends on spacetelescope/jdaviz#505
@mariobuikhuizen
fix: use sheet for dynamic embed and use new jdaviz class
7b82392
@mariobuikhuizen
Copy link
Contributor Author

I added a commit for the dynamic case. It needs the updated version of spacetelescope/jdaviz#505.

I don't have a newer version of the modified Vuetify package, but I can make one. I will then also update ipyvuetify with that version.

@havok2063
Copy link
Owner

Ok, thanks! I'll take a look at the dynamic case. I guess an updated modified Vuetify package isn't critical, especially if it requires coordination with ipyvuetify and jdaviz, or if it introduces any breaking changes to ipyvuetify.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariobuikhuizen @havok2063