Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Split Discover to only display if no current connection (#188) #549

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

phantomjinx
Copy link
Member

  • Splits the Discover plugin into 2:

    • Discover Core: preferences and header menu (always active)
    • Discover: page dashboad component (only active if no current connection)
  • discover-core

    • Moves preferences to this plugin
    • Moves header menu to this plugin
    • Adds as a new plugin, always active
    • By not including a plugin-path, the plugin will not be listed in the nav sidebar
  • discover

    • Dashboard only active if the connect-server does not contain a current connection

)

* Splits the Discover plugin into 2:
 * Discover Core: preferences and header menu (always active)
 * Discover: page dashboad component (only active if no current connection)

* discover-core
 * Moves preferences to this plugin
 * Moves header menu to this plugin
 * Adds as a new plugin, always active
 * By not including a plugin-path, the plugin will not be listed in the
   nav sidebar

* discover
 * Dashboard only active if the connect-server does not contain a current
   connection
@phantomjinx phantomjinx self-assigned this Oct 14, 2024
@phantomjinx phantomjinx merged commit e3c4a7b into hawtio:main Oct 16, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants