Add discovery SPI implementation for AWS #21
Conversation
| /** | ||
| * Access key of your account on EC2 | ||
| */ | ||
| AccessKey("access-key", STRING, false), |
There was a problem hiding this comment.
I'd prefer enum constants to be in capital letters.
There was a problem hiding this comment.
I only have minor comment about enum namings, other than that nice job @mmedenjak
Previously the AWS module supported only discovering members through the TcpIpJoiner mechanism. This was configured through the AwsConfig class. This mechanism is still available for backwards compatibility and here we will add support for the discovery SPI. By doing so, the user can now configure AWS using the old AwsConfig or the new discovery config and usage in Hazelcast core is simplified for future functionalities based on discovery SPI. Currently the discovery SPI implementation will transform the discovery configuration into the old AwsConfig and reuse the existing code. In the future both the deprecated TcpIpJoiner and the AwsConfig can be removed.
|
Test PASSed. |
|
Are we gonna send a cleanup PR to Hazelcast repository? |
|
@mesutcelik I am not sure about the release cycles of this plugin and IMDG. When is this plugin going to be released? WDYT? |
|
We can't maintain two implementation so cleanup should be applied to hazelcast 3.9. Discovery SPI is major change. We will probably release current implementation as major release: btw, hazelcast-aws is already supporting hazelcast 3.6+ only |
|
A cleanup is definitely in order but I would like to avoid breaking user code. It's great that this plugin is released this often, I was concerned that it would not be released in time for IMDG 3.9.
Which is why IMDG 3.9 would have to require AWS plugin 2.0 We can continue this on Slack, I'm merging this PR. |
Previously the AWS module supported only discovering members through the TcpIpJoiner mechanism. This was configured through the AwsConfig class. This mechanism is still available for backwards compatibility and here we will add support for the discovery SPI. By doing so, the user can now configure AWS using the old AwsConfig or the new discovery config and usage in Hazelcast core is simplified for future functionalities based on discovery SPI.
Currently the discovery SPI implementation will transform the discovery configuration into the old AwsConfig and reuse the existing code. In the future both the deprecated TcpIpJoiner and the AwsConfig can be removed.