You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However, there is a problem to consider. The cause of this log output is empty address list. This is not mutually exclusive with the errors NoCredentialsException and RestClientException. If address list is empty and one of the exceptions is thrown, user only will be notified by the empty address list. Upon fixing the empty address issue, they will see the other exceptions. We could solve this issue by using either an integer or an array instead of a boolean but I am not sure if the case I mentioned is a real life problem.
However, there is a problem to consider. The cause of this log output is empty address list. This is not mutually exclusive with the errors NoCredentialsException and RestClientException. If address list is empty and one of the exceptions is thrown, user only will be notified by the empty address list. Upon fixing the empty address issue, they will see the other exceptions. We could solve this issue by using either an integer or an array instead of a boolean but I am not sure if the case I mentioned is a real life problem.
@mtyazici I think that the "emptyList" needs a separate bool variable. Because we may need to see both the exception logs and the empty list log.
This fixes the issue #222
However, there is a problem to consider. The cause of this log output is empty address list. This is not mutually exclusive with the errors NoCredentialsException and RestClientException. If address list is empty and one of the exceptions is thrown, user only will be notified by the empty address list. Upon fixing the empty address issue, they will see the other exceptions. We could solve this issue by using either an integer or an array instead of a boolean but I am not sure if the case I mentioned is a real life problem.
@mtyazici I think that the "emptyList" needs a separate bool variable. Because we may need to see both the exception logs and the empty list log.
# for freeto subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue #222
However, there is a problem to consider. The cause of this log output is empty address list. This is not mutually exclusive with the errors
NoCredentialsExceptionandRestClientException. If address list is empty and one of the exceptions is thrown, user only will be notified by the empty address list. Upon fixing the empty address issue, they will see the other exceptions. We could solve this issue by using either an integer or an array instead of a boolean but I am not sure if the case I mentioned is a real life problem.