Issue 818, asynchronous deadlocks [API-2023] #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for silly-valkyrie-e996d9 failed.
|
emreyigit
reviewed
Apr 14, 2023
emreyigit
reviewed
Apr 17, 2023
emreyigit
approved these changes
Apr 17, 2023
zpqrtbnk
added a commit
that referenced
this pull request
Apr 18, 2023
* Issue 818, asynchronous deadlocks * Issue 818, fix tests + fix async
zpqrtbnk
added a commit
that referenced
this pull request
Jun 5, 2023
* Version 5.2.1 * Merge release fixes from master * Documentation latest version 5.2.1 * Tag v5.2.1 * Implement GetDistributedObjects [API-1916] (#805) * Implement GetDistributedObjects * GetDistributedObjects returns IReadOnlyCollection * Version 5.2.2 * Fix the DocFX documentation * Update public API * Documentation updates * Issue 818, asynchronous deadlocks [API-2023] (#819) * Issue 818, asynchronous deadlocks * Issue 818, fix tests + fix async * Doc/migration guide (#822) * Fix the DocFX documentation * temp * doc wip * doc wip * Documentation updates * Fix dependency injection (issue #823) [API-2025] (#824) * Fix dependency injection (issue #823) * Fix tests * Fix tests compatibility issue * Fix tests compatibility issue * Fix tests compatibility issue * Fix tests compatibility issue * Viridian cloud tests added. (cherry picked from commit a03eb33) * Revert bogus changes * Provide null logger factory if none configured * Fix viridian cloud tests * Fix API definition * Fix API definition * Fixing cloud tests * Fixing cloud tests * Fixing cloud tests * Fixing cloud tests * Fixing cloud tests * Fixing cloud tests * Fixing member connections for cloud * Documentation latest version 5.2.2 * Fixing cloud tests * Tag v5.2.2 * Fix merge --------- Co-authored-by: GitHub Actions (Trigger Release) <github-actions@hazelcast.com> Co-authored-by: emreyigit <emre.yigit@hazelcast.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on #818 and the corresponding JIRA ticket, client can hang when mixing synchronous (
task.GetAwaiter().Result) and synchronous (await task) patterns. This PR addresses one situation where aTaskCompletionSourcewas aggressively left synchronous where we should force it to be asynchronous.