This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Change DNS lookup method (#323) #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
leszko
reviewed
Jun 14, 2021
There was a problem hiding this comment.
Thanks a lot for the PR @npomaroli
I added one comment. Plus, would you mind sending the same PR to master? Then we'll merge them both and release.
|
I just realized that I misunderstood your comment and changed this PR to be directed to master. |
Add testcases for handling UnknownHostException and TimeoutException
leszko
approved these changes
Jun 15, 2021
|
@leszko can you say when v2.2.3 will be released? |
|
Yes, we'll release it tomorrow. |
|
This change is released in versions 1.5.6 and 2.2.3 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.