Skip to content

Commit

Permalink
Removing override of a method with a default implementation. (SAP#227)
Browse files Browse the repository at this point in the history
The word "Default" in the "DefaultSchemasCallback.java" let me assume
that I can derive classes from it to implement some method which are
needed in my use case. The fact that getAttribute is overridden in the
DefaultSchemasCallback.java leads to confusion and makes it even harder
to make it work with a derived class.
I think it is better to just let the default method in the interface
shining through.

Co-authored-by: Hristo Borisov <hristo.borisov@sap.com>
(cherry picked from commit 81fd5ff)
  • Loading branch information
davidsarosap authored and hborisov committed Mar 1, 2024
1 parent 9c32150 commit 1bc0b4e
Showing 1 changed file with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import jakarta.ws.rs.WebApplicationException;
import jakarta.ws.rs.core.Response;

import com.sap.scimono.entity.schema.Attribute;
import com.sap.scimono.entity.schema.Schema;

import java.util.List;
Expand Down Expand Up @@ -37,9 +36,4 @@ public boolean isValidSchemaName(String schemaName) {
throw new WebApplicationException(Response.Status.NOT_IMPLEMENTED);
}

@Override
public Attribute getAttribute(String path) {
throw new WebApplicationException(Response.Status.NOT_IMPLEMENTED);
}

}

0 comments on commit 1bc0b4e

Please # to comment.