Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

UBER-491 #3456

Merged
merged 1 commit into from
Jun 26, 2023
Merged

UBER-491 #3456

merged 1 commit into from
Jun 26, 2023

Conversation

BykhovDenis
Copy link
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@BykhovDenis
UBER-491
7356cc9 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis BykhovDenis requested review from haiodo and ThetaDR June 26, 2023 06:06
@BykhovDenis BykhovDenis self-assigned this Jun 26, 2023
@haiodo haiodo merged commit 66275fd into main Jun 26, 2023
@haiodo haiodo deleted the UBER-491_2 branch June 26, 2023 07:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@ThetaDR ThetaDR ThetaDR approved these changes

Assignees

@BykhovDenis BykhovDenis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BykhovDenis @haiodo @ThetaDR