Skip to content

UBER-298: Add readonly users option to the UserBoxItems component #3481

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2023
Merged

UBER-298: Add readonly users option to the UserBoxItems component #3481

merged 2 commits into from
Jul 5, 2023

Conversation

wazsone
Copy link
Contributor

@wazsone wazsone commented Jul 4, 2023

Contribution checklist

Brief description

Add readonly users option to the UserBoxItems component

Related links

https://github.com/Ezthera/ezqms/pull/524

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • [] - Are required links are linked to PR?
  • - Does new code is well documented ?

@wazsone
add readonly users to the UserBoxItems component
aeffb77 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone wazsone requested review from haiodo and BykhovDenis July 4, 2023 16:18
@wazsone wazsone self-assigned this Jul 4, 2023
haiodo
haiodo reviewed Jul 4, 2023
View reviewed changes
plugins/contact-resources/src/components/UserBoxItems.svelte Outdated
@@ -64,6 +68,10 @@
)
}

function getPersons (employees: Ref<Employee>[]) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to pass employeeByIdStore as parameter, over wise svelte will not update view if new employee will arrive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Fixed

@wazsone
pass employeeByIdStore as a parameter
5015404 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone wazsone requested a review from haiodo July 4, 2023 18:55
@haiodo haiodo merged commit 2f78ec0 into main Jul 5, 2023
@haiodo haiodo deleted the UBER-298/readonly-users branch July 5, 2023 07:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@haiodo haiodo

@BykhovDenis BykhovDenis

Assignees

@wazsone wazsone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wazsone @haiodo