Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

UBER-535 #3486

Merged
merged 5 commits into from
Jul 10, 2023
Merged

UBER-535 #3486

merged 5 commits into from
Jul 10, 2023

Conversation

BykhovDenis
Copy link
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@BykhovDenis BykhovDenis requested a review from haiodo July 7, 2023 07:16
@BykhovDenis BykhovDenis self-assigned this Jul 7, 2023
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
name: user.email,
description: '',
archived: false,
private: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be private?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we should have possibility to show events to another users in future

@@ -36,7 +36,7 @@
: new Date(new Date(currentDate).setHours(0, 0, 0, 0))
</script>

<table class="antiTable">
<table class="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<table class="">
<table>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use table without class?

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis BykhovDenis merged commit 5e3bfac into main Jul 10, 2023
@BykhovDenis BykhovDenis deleted the UBER-535 branch July 10, 2023 15:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants