Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove the unused implicit attribute _cc_toolchains. #372

Closed
wants to merge 3 commits into from
Closed

Conversation

mikesinouye
Copy link
Collaborator

@mikesinouye mikesinouye commented Dec 12, 2024

CC toolchains are gathered from the line:

toolchains = use_cc_toolchains(),

Signed-off-by: Mike Inouye <mikeinouye@google.com>
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Signed-off-by: Mike Inouye <mikeinouye@google.com>
@katre
Copy link

katre commented Dec 18, 2024

Can your project upgrade to Bazel 7.4.1? That should resolve the failure, and is much more up-to-date than the current version of 6.x.

@mikesinouye
Copy link
Collaborator Author

While that is the best fix, briefly experimenting with bazel 7 seems like it requires a cascade of dependency upgrades/fixes. At this point, the time is likely better spent upgrading to bzlmod instead. @QuantamHD should we stick with bazel6 for now, resolve our internal issue with a patch, and plan to spend time for a proper bazel 8 + bzlmod migration sometime next year?

@QuantamHD
Copy link
Collaborator

Might want to just go with a patch internally, and move to bzlmod

@mikesinouye
Copy link
Collaborator Author

Sounds good, let's go with that.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants