Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

misc/magic: remove conda-forge deps #195

Merged
merged 6 commits into from
Mar 29, 2022
Merged

Conversation

proppy
Copy link
Contributor

@proppy proppy commented Mar 11, 2022

  • remove conda-forge deps (tcsh)
  • use cdt for x11 libs

Related to #193

@ajelinski
Copy link
Contributor

Please rebase. #185 has been merged and CDT packages aren't a problem for conda-ci anymore.

@ajelinski
Copy link
Contributor

Oh and you need to solve the library building problem.
I've tested building this package and it succeeds but the package built doesn't contain the tclmagic.so.
The log contains:

2022-03-25T16:38:43.1342201Z --- installing runtime files to $PREFIX/lib
2022-03-25T16:38:43.1342774Z windClient.c:33:10: fatal error: database/database.h: No such file or directory
2022-03-25T16:38:43.1343327Z    33 | #include "database/database.h"
2022-03-25T16:38:43.1343775Z       |          ^~~~~~~~~~~~~~~~~~~~~
2022-03-25T16:38:43.1344175Z compilation terminated.

...quite a lot such lines...

2022-03-25T16:38:43.1376428Z In file included from tclmagic.c:30:
2022-03-25T16:38:43.1376853Z ../utils/main.h:27:10: fatal error: database/database.h: No such file or directory
2022-03-25T16:38:43.1377175Z    27 | #include "database/database.h"
2022-03-25T16:38:43.1377414Z       |          ^~~~~~~~~~~~~~~~~~~~~
2022-03-25T16:38:43.1377653Z compilation terminated.
2022-03-25T16:38:43.1378146Z make[2]: *** No rule to make target '../bplane/libbplane.o', needed by 'tclmagic.so'.  Stop.

@proppy
Copy link
Contributor Author

proppy commented Mar 29, 2022

It seems to work for me:

--- making header file database/database.h

Let's see if the CI is happy about it.

@ajelinski
Copy link
Contributor

It's great to have it working finally. :)
I was a little worried about these libc/libm warnings: https://github.com/hdl/conda-eda/runs/5738804986?check_suite_focus=true#step:4:7367
but I've just checked locally that libc.so.6 is present in the build environment with these changes so there shouldn't be any issues related to glibc.

@ajelinski ajelinski merged commit 360c2c3 into hdl:master Mar 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants