Replace log_process_action to append_info_to_payload

[fbbergamo]

This implementation replace log_process_action to append_info_to_payload that way the status should be present in ActiveSupport::Notifications's payload and at the log

It's based on what AR is doing:
https://github.com/rails/rails/blob/92703a9ea5d8b96f30e0b706b801c9185ef14f0e/activerecord/lib/active_record/railties/controller_runtime.rb#L35

No test change was needed but one test was include.

[benlovell]

Is there any appetite for landing this change? Happy to help get it across the line if anything outstanding.

[pjg]

Typo, returns => return

[jonpaul]

Would love to see this re-reviewed.

[myriky]

I hope this PR will be merge.

[fbbergamo]

@rafaelfranca @lucasmazza
Is there anything that I may help to merge this PR?

[rafaelsales]

This broke my logging when I upgraded from 4.3.0 to 4.4.0, and 4.4.1 is still broken. I'm on Rails 5.1.4

I noticed that logs in my app started reporting Completed 401 Unauthorized when the action failed with an unhandled exception. The client still receives 500 Internal Error, but the log reports 401.

I'm checking how to fix it

@rafaelfranca @lucasmazza @fbbergamo

[tegon]

@rafaelsales I'm not sure it's related, we released this on v4.4.0

[rafaelsales]

@tegon sorry, I had a typo in the version numbers of my comment. Just fixed.

If I revert this particular commit, the previous behavior is established. I'm building a test case to reproduce.

[rafaelsales]

@tegon Here's the test case to reproduce - this commit was made on top of the latest master:
rafaelsales@302c53e

I tried to dig in a little bit and I found out that in the following snippet of this PR, the payload[:exception] always returns nil even if a public action raises an error, so the 401 status is added to the payload.

        def append_info_to_payload(payload)
          super
          payload[:status] ||= 401 unless payload[:exception]
        end

[tegon]

@rafaelsales I see. Can you open a PR for this? If you don't know how to solve it, just add a failing test example so that other person can work on it.

[rafaelsales]

Sure, thanks

[stanhu]

I did some investigation on this. Cross-linking my thoughts in the Lograge issue tracker: roidrage/lograge#67 (comment)