-
-
Notifications
You must be signed in to change notification settings - Fork 556
[console] Use the git commit ID for the version #2201
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
👍 for this.... |
Not sure how this may affect the self-update command |
@jmolivas It doesn't affect it on the drupal-vm-generator project. It still works as expected. |
I tested the changes and looks good, but I think will be a little confusing for regulars users, will be better is the git hash or last commit is presented as extra information. |
In most scenarios, I'd imagine that regular users would download a stable tagged version, in which case that's what they would see - the same as they would now. |
With Github you have the checkbox "This is a pre-release" but I never used it. |
I tried this approach at the Launcher, since is the project distributed as a phar. I agree this is helpful for debugging, but I think the hash added the commit could be confusing for users. |
This uses the git tag for the version, and adds the number of commits ahead and the commit ID if you are using a version that has commits since the last tag.
This should make debugging easier as it's much clearer which version a user is running, and also there's no need to manually increase the version number each time.
This results in output like this: