Skip to content

[generate:command] Regression with the Annotation stops custom translations from working #4282

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codebymikey
Copy link

The #4074 PR introduced a regression with the annotations.

The DrupalCommand annotation was missing the @ annotation token prefix, which stops translations from being detected for generated commands as it fails validation and marked as an invalid command in the following:

if (!$annotationValidator->isValidCommand(
$serviceDefinition->getClass()
)
) {
$invalidCommands[] = $name;
continue;
}

The DrupalCommand annotation was missing the '@' annotation token.
This stops translations from being detected for generated commands.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant