Make package protected gRPC classes public #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…namically create gRPC client proxies from user code. The methods are already public. Make ChannelProducer public so that it can be properly injected into classes.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
io.helidon.microprofile.grpc.client.GrpcClientProxyBuilderclass is package protected even though its methods are public. This class is a builder and has a private constructor but is not usable in client code unless the class itself is made public.The
io.helidon.microprofile.grpc.client.ChannelProducerclass is package protected so even though it is a CDI bean it cannot be injected into any other beans in client code.