4.x: Disable only the slowest test in FileSystemWatcherTest #9682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
force-pushed
the
file-system-watcher-test-enable
branch
from
e2f8483 to
82f3a08
Compare
Captain1653
force-pushed
the
file-system-watcher-test-enable
branch
from
82f3a08 to
a3649ab
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now all tests in
FileSystemWatcherTestare disabled, because they are too slow. But only one test is too slowtestPollingSymLink. Is it better to disable only the specific test? I'm not sure, but 4 seconds look like not so much time.