Fix for Rust 1.85.0 #953
Merged
Fix for Rust 1.85.0 #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldjeffrey
approved these changes
Feb 20, 2025
madninja
reviewed
Feb 21, 2025
| @@ -34,7 +34,7 @@ where | |||
| Box::pin( | |||
| handle | |||
| .map_err(anyhow::Error::from) | |||
| .and_then(|result| async move { result.map_err(anyhow::Error::from) }), | |||
| .and_then(|result| async move { result }), | |||
There was a problem hiding this comment.
huh? this doesn't actually do anything right?
There was a problem hiding this comment.
It does
|
34 | / Box::pin(
35 | | handle.map_err(anyhow::Error::from),
36 | | // .and_then(|result| async move { result }),
37 | | )
| |_________^ expected `Result<(), Error>`, found `Result<Result<(), Error>, Error>`
|
= note: expected enum `std::result::Result<(), _>`
found enum `std::result::Result<std::result::Result<(), anyhow::Error>, _>````
kurotych
approved these changes
Feb 21, 2025
bbalser
approved these changes
Feb 21, 2025
michaeldjeffrey
pushed a commit
that referenced
this pull request
Feb 25, 2025
michaeldjeffrey
pushed a commit
that referenced
this pull request
Feb 25, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.